[Doc][KubeRay] Add description tables for RayCluster Status in the observability doc #47462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…servability doc Signed-off-by: Rueian <[email protected]>
rueian
requested review from
architkulkarni,
maxpumperla,
pcmoritz,
kevin85421 and
a team
as code owners
|
Hi @kevin85421, could you take a look? |
kevin85421
added
the
kuberay
anyscalesam
added
P1
kevin85421
approved these changes
Sep 4, 2024
…servability doc Signed-off-by: Rueian <[email protected]>
…servability doc Signed-off-by: Rueian <[email protected]>
|
Updated: |
kevin85421
reviewed
Sep 4, 2024
|
|
||
|
|
||
|
|
||
| #### RayCluster `.Status.Conditions` |
There was a problem hiding this comment.
I remember that .Status.Conditions has a feature flag. Can you explain how to enable this feature?
There was a problem hiding this comment.
Might help also add a warning header here that it's an alpha feature
…servability doc Signed-off-by: Rueian <[email protected]>
…servability doc Signed-off-by: Rueian <[email protected]>
angelinalg
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Just some style nits. Please consider using Vale to find these issues in the future. Please excuse any inaccuracies I introduced in my suggestions and correct as needed. Happy to answer any questions you have about the suggestions. Thanks for your contribution!
…servability doc (Vale) Signed-off-by: Rueian <[email protected]>
…servability doc (Vale) Signed-off-by: Rueian <[email protected]>
|
Hi @angelinalg, thank you so much for reviewing. All suggestions are applied. |
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
…servability doc (ray-project#47462) Signed-off-by: Rueian <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KubeRay v1.2.1 comes with new CRD status improvements that are better documented, specifically the new
RayClusterStatus.Conditionsfield.This PR adds a description table for known values of the new
RayClusterStatus.Conditions, letting users know how to interpret them for tracking RayCluster status or debugging.Another table for the old
RayClusterStatus.Stateis also added to this PR so users can compare the differences between these two fields.Preview: https://anyscale-ray--47462.com.readthedocs.build/en/47462/cluster/kubernetes/user-guides/observability.html
